Open
Conversation
thomasgouveia
force-pushed
the
main
branch
2 times, most recently
from
f6e5c9b to
0251b49
Compare
Member
|
What is the status of this PR ? |
jlabatut
force-pushed
the
35-add-video-attachments
branch
from
cea8cc9 to
159bca4
Compare
Member
|
@jlabatut Hey, i was reviewing you're PR, and it doesn't work in mocked environment, any reasons ? |
leofvo
requested review from
JeremyLARDENOIS,
croumegous and
sylvain-reynaud
jlabatut
force-pushed
the
35-add-video-attachments
branch
from
425d6fa to
8f726b4
Compare
MaloPolese
requested changes
Jan 12, 2023
| <CopyToClipboard | ||
| onCopy={() => { | ||
| snackbarService.createSnackbar( | ||
| tUsers('profile.tabs.attachments.content.list.clipboard'), |
Member
There was a problem hiding this comment.
Suggested change
| tUsers('profile.tabs.attachments.content.list.clipboard'), | |
| t('profile.tabs.attachments.content.list.clipboard', { ns: 'user' }), |
Comment on lines
+16
to
+17
| const { t: tUsers } = useTranslation('users') | ||
| const { t: tAttachments } = useTranslation('attachments') |
Member
There was a problem hiding this comment.
use only one useTranslation('user') or useTranslation('attachements') then if you want to change use namespace
t('profile.tabs.attachments.content.list.clipboard', { ns: 'user' })
| }} | ||
| text={url} | ||
| > | ||
| <Tooltip title={tAttachments<string>('actions.copyToClipboard')}> |
Member
There was a problem hiding this comment.
Suggested change
| <Tooltip title={tAttachments<string>('actions.copyToClipboard')}> | |
| <Tooltip title={t<string>('actions.copyToClipboard')}> |
| useEffect(() => { | ||
| /* Since the attachments are not invalidated after a video update, we need to refetch them here */ | ||
| if (data) refetch() | ||
| }, []) |
Member
There was a problem hiding this comment.
Suggested change
| }, []) | |
| }, [data]) |
| } | ||
| } | ||
| } | ||
| }, [videoId, data]) |
Member
There was a problem hiding this comment.
maybe
Suggested change
| }, [videoId, data]) | |
| }, [videoId, data, fields]) |
| } | ||
| disablePadding | ||
| > | ||
| <ListItemButton onClick={handleToggle(item)}> |
Comment on lines
+178
to
+181
| {!isLoading && | ||
| (data && | ||
| data.items.length > 0 && | ||
| data.items.length < data.totalCount ? ( |
Member
There was a problem hiding this comment.
Maybe you can group everything into one function for clarity
| /> | ||
| </Box> | ||
| ) : ( | ||
| !data || |
Member
There was a problem hiding this comment.
Maybe you can group everything into one function for clarity
| getVideoAttachments: builder.query<PaginatedAttachments, string>({ | ||
| query: (videoId: string) => { | ||
| return `${Endpoint.Attachments}/video/${videoId}` | ||
| return `${Endpoint.Attachments}/video/${videoId}?pageSize=50&page=1` // TODO : remove pagination from attachment service (only for /video/id) |
| useEffect(() => { | ||
| /* Since the attachments are not invalidated after a video update, we need to refetch them here */ | ||
| if (attachments) refetch() | ||
| }, []) |
Member
There was a problem hiding this comment.
Suggested change
| }, []) | |
| }, [attachments]) |
alexandrebrg
force-pushed
the
main
branch
5 times, most recently
from
2dd0535 to
f285c93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #35
How to test :